Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with yarn version 2+ with PnP #34

Closed
sdankel opened this issue Jan 24, 2023 · 3 comments · Fixed by #35
Closed

Doesn't work with yarn version 2+ with PnP #34

sdankel opened this issue Jan 24, 2023 · 3 comments · Fixed by #35
Labels
bug Something isn't working

Comments

@sdankel
Copy link
Contributor

sdankel commented Jan 24, 2023

publish-vscode-extension Version Operating System
1 osx

Description

It fails at yarn list --prod --json, because yarn 2 and 3 don't have yarn list

This is preventing users from being able to upgrade to newer versions of yarn while using this action.

I see this is a problem in the underlying vsce package as well. microsoft/vscode-vsce#517

Expected Behavior

It will need to check the version of yarn and use the appropriate commands for the yarn version. Either that, or change the yarn argument from a boolean to a number or string to represent the version.

Actual Behavior

It fails, example

Steps to Reproduce

  1. Run it on any package that is using yarn version > 1 with PnP
@sdankel
Copy link
Contributor Author

sdankel commented Jan 24, 2023

It looks like a workaround for this is to pass dependencies: false to vsce: microsoft/vscode-vsce#439

This bypasses the yarn list check which is fine for yarn v2+ with pnp (no node_modules). I propose we add an option to this action like dependencies: boolean, similar to vsce.

@sdankel sdankel changed the title Doesn't work with yarn version 3 Doesn't work with yarn version 2+ with pnp Jan 24, 2023
@HaaLeo HaaLeo added the bug Something isn't working label Jan 24, 2023
@sdankel sdankel changed the title Doesn't work with yarn version 2+ with pnp Doesn't work with yarn version 2+ with PnP Jan 24, 2023
@HaaLeo
Copy link
Owner

HaaLeo commented Jan 31, 2023

Hi @sdankel thx for your contribution. I will take a look as soon as possible :)

@HaaLeo
Copy link
Owner

HaaLeo commented Apr 1, 2023

published with v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants