Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate can the e2e test action be improved to handle test setup/teardown better #369

Closed
jpeuralinna opened this issue Jun 7, 2021 · 1 comment
Assignees
Labels
Projects

Comments

@jpeuralinna
Copy link
Contributor

Currently setup (creating results folder) and teardown (copying files to results folder and uploading artefacts) are done as part of the workflow file that calls the action.
It would make creating workflows easier, if these steps would be done inside the action itself.

@jpeuralinna jpeuralinna created this issue from a note in Jore4 (Project backlog) Jun 7, 2021
@jpeuralinna jpeuralinna self-assigned this Jun 8, 2021
@jpeuralinna jpeuralinna moved this from Project backlog to In progress in Jore4 Jun 9, 2021
@jpeuralinna
Copy link
Contributor Author

Tried to find a way to run upload-artifact action inside our e2e-action, but running actions inside actions is not supported by github yet. So all the possible solutions are really hacky and propably not worth doing, since our solution works already and adding workarounds would just make the setup more complex.

Issue for adding possibility to run actions within action: actions/runner#612
So it might be added at some point, then we could make our actions a bit cleaner.

Jore4 automation moved this from In progress to Done Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Jore4
Done
Development

No branches or pull requests

1 participant