Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs with sub component #4

Open
GuillaumeJasmin opened this issue Aug 2, 2018 · 5 comments
Open

Bugs with sub component #4

GuillaumeJasmin opened this issue Aug 2, 2018 · 5 comments

Comments

@GuillaumeJasmin
Copy link
Owner

Currently, fixed columns doesn't work well with sub component.

Tests and improvement are needed.

See #2 (comment)

@multum
Copy link

multum commented Aug 17, 2018

To solve this problem(for version 1.0.0-beta.8), you need to add a style to the SubComponent

.sub_component .rt-table {
  overflow: visible !important;
}

Example

@GuillaumeJasmin
Copy link
Owner Author

Thanks ! Yes it fix some issue ! :)

But in a full stable version, I think the scroll of tables must be separate, no ? Currently, table scrolls are synced, but I don't know if this behavior is really what we want ?

I don't currently work with sub component so I'm not sure what is the best.

@multum
Copy link

multum commented Aug 21, 2018

@GuillaumeJasmin If the subcomponent occupies the entire width of the line, it does not need its own scroll. In my opinion, everything should work fine, but I do not have the opportunity to test version 0.1

@kapil-chandra
Copy link

Related to this, if the subcomponent is another react-table, the header row of that sub-component is being shifted down (see screenshot) when a row is inserted into that subcomponent table due to the updateRowsPosition function incrementing all nested header rows instead of just the header rows of the root table.

Changing the css selector to look for the header of the top level table seems to work:

const headerRows = document.querySelectorAll(`.${this.uniqClassName} > .rt-table > .rt-thead`);     

image

@GuillaumeJasmin
Copy link
Owner Author

Hi @kapil-chandra
Thanks for your feedback :)
I will fix it soon with your fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants