Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple task #133

Open
atherdon opened this issue Mar 24, 2019 · 4 comments
Open

simple task #133

atherdon opened this issue Mar 24, 2019 · 4 comments
Assignees

Comments

@atherdon
Copy link
Member

All is simple:

  • review our current codebase
  • find out that we have 4 components that doing the same thing
  • make one component that will work in our 4 cases
  • after publishing on npm - install to react-pdf-sandbox and check is everything working OK
    @hirdbluebird do you want to grab it?
@hirdbluebird
Copy link
Member

@atherdon ku,
razbloch menya

@atherdon
Copy link
Member Author

atherdon commented Mar 28, 2019

@atherdon
Copy link
Member Author

Additional feature: can you update our Readme file and change the explanation of what and how we're including our code right now.

@atherdon
Copy link
Member Author

atherdon commented Apr 2, 2019

looks like we can debug our module at react-pdf-print repository. I published your latest version and was able to see warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants