Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next]: Test recorded shifts update in InlineLift pass #1507

Open
tehrengruber opened this issue Mar 20, 2024 · 0 comments
Open

[next]: Test recorded shifts update in InlineLift pass #1507

tehrengruber opened this issue Mar 20, 2024 · 0 comments

Comments

@tehrengruber
Copy link
Contributor

The update of the recorded shifts in the InlineLift pass has reached a level that is not feasible to be tested with manually written test data. There are just too many combinations that need to be tested, so we should write some infrastructure that automatically generates various combinations and checks that the recorded shifts that are returned as a result of this pass match what the TraceShifts pass gives. Note that it is in any case required to do the update during the pass since we need the updated recorded shifts in the pass itself.

See here for an example where we manually update the recorded shifts:

# TODO(tehrengruber): This is not tested properly. There are too many combinations of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant