Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove floordiv builtin #1136

Open
havogt opened this issue Jan 20, 2023 · 0 comments
Open

Remove floordiv builtin #1136

havogt opened this issue Jan 20, 2023 · 0 comments
Labels
gt4py.next Issues concerning the new version with support for non-cartesian grids. triage: bug Something isn't working
Projects
GridTools

Comments

@havogt
Copy link
Contributor

havogt commented Jan 20, 2023

Since we support casting now, the following TODO can be implemented

gt4py/src/functional/ffront/itir_makers.py

Line 156 in 0c5c1a2

# TODO(tehrengruber): Use int(floor(left/right)) as soon as we support integer casting

  • Check all mentions of floordiv are removed
  • Double-check that floordiv is tested properly
@havogt havogt added triage: bug Something isn't working gt4py.next Issues concerning the new version with support for non-cartesian grids. labels Jan 20, 2023
@gridtoolsjenkins gridtoolsjenkins added this to Triage in GridTools Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gt4py.next Issues concerning the new version with support for non-cartesian grids. triage: bug Something isn't working
Projects
GridTools
  
Triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@havogt