Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Applying "Legacy Application" themes via Gradience #805

Open
1 task done
orowith2os opened this issue Aug 14, 2023 · 7 comments
Open
1 task done

feat: Applying "Legacy Application" themes via Gradience #805

orowith2os opened this issue Aug 14, 2023 · 7 comments
Labels
enhancement New feature or request feature-request
Milestone

Comments

@orowith2os
Copy link

orowith2os commented Aug 14, 2023

Feature description

Tweaks has a feature that allows the user to set "Legacy Application" themes; this is currently used so Gradience can theme GTK3 applications, by setting adw-gtk3. Gradience could set this option itself when applicable, so Tweaks is no longer required for people to set the GTK3/"Legacy Applications" theme.

image

Additional Context

It needs to be investigated to ensure that this will affect pure GTK4 (no Libadwaita).

We're looking into migrating this setting to Gradience to minimize the amount of features that Tweaks and/or a future Tweaks alternative needs to handle - Gradience, being a theming app for GNOME, seems like the most appropriate place to handle this.

https://gitlab.com/OroWith2Os/toggle

Did you read the Code of Conduct?

@orowith2os orowith2os added enhancement New feature or request feature-request labels Aug 14, 2023
@github-actions
Copy link
Contributor

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your issue as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ

@daudix daudix added this to the 0.8.0 milestone Aug 14, 2023
orowith2os added a commit to orowith2os/flatpak-builder-lint that referenced this issue Aug 14, 2023
hfiguiere pushed a commit to flathub-infra/flatpak-builder-lint that referenced this issue Aug 15, 2023
@orowith2os
Copy link
Author

The Flathub issue is no longer a blocker for this.

@0xMRTT
Copy link
Member

0xMRTT commented Aug 15, 2023

@orowith2os what about merging the entire theme section of toogle into gradience ?

@0xMRTT
Copy link
Member

0xMRTT commented Aug 15, 2023

Fixed!!!!

@0xMRTT
Copy link
Member

0xMRTT commented Aug 15, 2023

@daudix-UFO can you try ?

@orowith2os
Copy link
Author

@0xMRTT that could work, but I need to look at Tweaks for what's necessary to get this going first. And I'm not sure if handling non-GTK theming is in scope for Gradience yet.

@daudix
Copy link
Member

daudix commented Aug 17, 2023

@daudix-UFO can you try ?

Tested, works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-request
Projects
Status: Todo
Development

No branches or pull requests

3 participants