Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix math domain error #169

Closed
wants to merge 1 commit into from
Closed

Fix math domain error #169

wants to merge 1 commit into from

Conversation

yaakiyu
Copy link

@yaakiyu yaakiyu commented Apr 29, 2022

when memory bytes was't gotten collectly

Rationale

When memory bytes was't gotten collectly, the jsk command wouldn't run.

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/discord/ext/commands/core.py", line 168, in wrapped
    ret = await coro(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/jishaku/features/root_command.py", line 102, in jsk
    f"{natural_size(mem.uss)} of which unique to this process.")
  File "/usr/local/lib/python3.9/dist-packages/jishaku/features/root_command.py", line 46, in natural_size
    power = int(math.log(size_in_bytes, 1024))
ValueError: math domain error

I checked mem.uss and returned 0.
Maybe because the bot is runnning on WSL, but I want to run jsk command.
So I created a pull request.
I'm Japanese, so my English may look clumsy. Sorry.

Summary of changes made

Only put try and except ValueError: power=0.

Checklist

  • This PR changes the jishaku module/cog codebase
    • These changes add new functionality to the module/cog
    • These changes fix an issue or bug in the module/cog
    • I have tested that these changes work on a production bot codebase
    • I have tested these changes against the CI/CD test suite
    • I have updated the documentation to reflect these changes
  • This PR changes the CI/CD test suite
    • I have tested my suite changes are well-formed (all tests can be discovered)
    • These changes adjust existing test cases
    • These changes add new test cases
  • This PR changes prose (such as the documentation, README or other Markdown/RST documents)
    • I have proofread my changes for grammar and spelling issues
    • I have tested that any changes regarding Markdown/RST syntax result in a well formed document

when memory bytes was't gotten collectly
@Gorialis Gorialis closed this in aaa1b89 Apr 29, 2022
clari7744 pushed a commit to clari7744/jishaku that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant