-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shifted Moveable in RTL mode with scrollbar #7968
Conversation
Size Change: +105 B (0%) Total Size: 2.13 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed some RTL+zoom oddities, can you also see all of them? Screen.Recording.2021-06-17.at.23.26.17.mov |
Hm, didn't see it before but yes, now I can see that the horizontal scrolling doesn't seem to be working. And yes, looks like it was working as expected before in Safari and now is not. It's also not working as expected in Firefox anymore so looks like this fix should be for Chrome only. I'll move this back to the backlog and expand the scope to generally fixing the issues with Zoom. |
@miina is this one still relevant? |
I think we can close, thanks for checking. |
Summary
Considers the scrollbar when in RTL mode and the user has zoomed in enough for the vertical scrollbar to be visible.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
QA
See above.
Checklist
Type: XYZ
label to the PRFixes #7638