Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skaffold should have warnings when using jib builder with --platform flag #7820

Closed
ericzzzzzzz opened this issue Aug 28, 2022 · 2 comments
Closed

skaffold should have warnings when using jib builder with --platform flag #7820

ericzzzzzzz opened this issue Aug 28, 2022 · 2 comments
Labels
area/multi-platform kind/bug Something isn't working priority/p2 May take a couple of releases

Comments

@ericzzzzzzz
Copy link
Contributor 

skaffold build --platform linux/arm64,linux/amd64 --default-repo=xxxx --namespace xxx
  • the build will succeed but the build artifact is an amd64 image, before the base image configured here jib.from.image = 'gcr.io/google-appengine/openjdk:8' in build.gradle file is an amd64 image
  • Most likely skaffold will not inspect build.gradle future, so we probably want to show a warning like jib builder is used, --platform flag is ignored
@renzodavid9 renzodavid9 added priority/p2 May take a couple of releases area/multi-platform kind/bug Something isn't working labels Aug 29, 2022
@renzodavid9
Copy link
Contributor

This PR was created to change the behavior from Jib itself. The PR is already merged, we'll need to wait for the next release.

@gsquared94
Copy link
Collaborator

fixed in #7831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/multi-platform kind/bug Something isn't working priority/p2 May take a couple of releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@renzodavid9 @gsquared94 @ericzzzzzzz