Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kaniko should abort if pkg/filesystem/resolve.go ResolvePaths() founds symlink target doesn't exist #2709

Open
santiagorr opened this issue Aug 29, 2023 · 0 comments · May be fixed by #2710
Open

Kaniko should abort if pkg/filesystem/resolve.go ResolvePaths() founds symlink target doesn't exist #2709

santiagorr opened this issue Aug 29, 2023 · 0 comments · May be fixed by #2710
Labels
area/errorhandling For all bugs having to do with handling problems during kaniko execution area/symlinks kind/enhancement New feature or request kind/friction needs-discussion Items which need more discussion before commitment priority/p1 Basic need feature compatibility with docker build. we should be working on this next.

Comments

@santiagorr
Copy link

Actual behavior

Kaniko is being used by Debian's Salsa CI (a CI toolkit in the Debian's gitlab instance). Debian is also in the process to being /usr-merged. A recent upload of the debianutils package introduced a related bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050784

Due to that bug, the images built by kaniko were broken, and pushed to the salsa ci registry. All the Salsa CI (package build) jobs
were unable to run.

Expected behavior

It would had really help if kaniko exited with error when it found this error:
https://salsa.debian.org/salsa-ci-team/pipeline/-/jobs/4620766#L291

So a still working image could be used by all the Debian Salsa CI users.

To Reproduce
Steps to reproduce the behavior:

  1. Run kaniko as here: https://salsa.debian.org/salsa-ci-team/pipeline/-/blob/master/.images-ci.yml with a debian image installing debianutils 5.10

Additional Information

Given the debian build system and mirrors, it is not possible right now to provide a Dockerfile that install debianutils 5.10. I will do once it gets fetched by snapshot.debian.org.

Triage Notes for the Maintainers

Description Yes/No
Please check if this a new feature you are proposing
  • - [ No ]
Please check if the build works in docker but not in kaniko
Please check if this error is seen when you use --cache flag
See See salsa.debian.org/salsa-ci-team/pipeline/-/commit/7788516dd8b2a3fd82f7cb62064bae5a2ba79a3b
Please check if your dockerfile is a multistage dockerfile
  • - [ No ]
@santiagorr santiagorr linked a pull request Aug 29, 2023 that will close this issue
Draft
4 tasks
@aaron-prindle aaron-prindle added needs-discussion Items which need more discussion before commitment priority/p1 Basic need feature compatibility with docker build. we should be working on this next. area/symlinks kind/friction kind/enhancement New feature or request area/errorhandling For all bugs having to do with handling problems during kaniko execution labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/errorhandling For all bugs having to do with handling problems during kaniko execution area/symlinks kind/enhancement New feature or request kind/friction needs-discussion Items which need more discussion before commitment priority/p1 Basic need feature compatibility with docker build. we should be working on this next.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make kaniko abort when pkg/filesystem/resolve.go ResolvePaths() found… santiagorr/kaniko
2 participants
@santiagorr @aaron-prindle