Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when environment map contains null values #3671

Closed
oliver-brm opened this issue May 14, 2022 · 3 comments
Closed

Improve error message when environment map contains null values #3671

oliver-brm opened this issue May 14, 2022 · 3 comments

Comments

@oliver-brm
Copy link
Contributor

Environment:

  • Jib version: 3.2.1
  • Build tool: Gradle 7.4.1
  • OS: N/A

Description of the issue:

Jib's checks if any of the keys and values set in the container.environment configuration is null, which is super helpful. However, the error message when an container.environment value is null currently reads only like this: "environment map contains null values". For someone not so deep into Jib, this could be not enough of a hint to the actual problem.

Expected behavior:
The error message should contain the offending keys, for example like so: "environment map contains null values for key(s): FOO, BAR, BAZ"

Steps to reproduce:

  1. Use an environment map with a value set to null
  2. Run jib (e.g. ./gradlew jib)

I can offer a solution via PR.

@elefeint
Copy link
Contributor

Thanks, this seems like a useful improvement.

elefeint pushed a commit that referenced this issue May 17, 2022
… (#3672)

Co-authored-by: Oliver Marienfeld <schwaigbub@gmail.com>
@mpeddada1
Copy link
Contributor

Fixed with #3672

@mpeddada1
Copy link
Contributor

Thank you for your contribution! jib-maven-plugin and jib-gradle-plugin 3.3.0, jib-core 0.22.0 and jib-cli 0.11.0 have been released with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants