Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry mirror config to jib-core API and Jib global config #2999

Merged
merged 24 commits into from
Jan 21, 2021

Conversation

chanseokoh
Copy link
Member

@chanseokoh chanseokoh commented Jan 13, 2021

Towards #1396.

  • Jib Core
    • Adds Containerizer.withRegistryMirrors(...) to the jib-core API.
  • Jib Maven/Gradle plugins
{
  "disableUpdateCheck": false,
  "registryMirrors": [
    {
      "registry": "registry-1.docker.io",
      "mirrors": ["mirror.gcr.io", "localhost:5000"]
    },
    {
      "registry": "quay.io",
      "mirrors": ["private-mirror.test.com"]
    }
  ]
}

@google-cla google-cla bot added the cla: yes label Jan 13, 2021
@chanseokoh chanseokoh marked this pull request as ready for review January 14, 2021 22:31
@chanseokoh
Copy link
Member Author

This is ready for review. I'm curious what you feel about storing and returning a map and handling errors in this way.

@loosebazooka
Copy link
Member

description or bug?

@chanseokoh
Copy link
Member Author

chanseokoh commented Jan 20, 2021

Sorry, updated the doc. Just realized I forget updating the jib-core CHANGELOG. Will update soon.

@chanseokoh
Copy link
Member Author

I forget updating the jib-core CHANGELOG. Will update soon.

Nah, I will update CHANGELOG once the registry mirror feature is fully working.

Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I got here late, but generally I think we use the style of abstract/interface for method inputs and return types? So ListMultimap is the type we expose and ImmutableListMultimap is an impl detail?

@loosebazooka
Copy link
Member

I think this looks good to me

@mpeddada1
Copy link
Contributor

Maybe I got here late, but generally I think we use the style of abstract/interface for method inputs and return types? So ListMultimap is the type we expose and ImmutableListMultimap is an impl detail?

Ah right, thanks for clarifying! In that case I don't think my comments apply here. Sorry about that.

@chanseokoh chanseokoh merged commit b0d05c7 into master Jan 21, 2021
@chanseokoh chanseokoh deleted the add-mirror-configs branch January 21, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants