Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring codegen: update and simplify generator logic after recent changes in gapic client generation #2722

Open
zhumin8 opened this issue Mar 19, 2024 · 1 comment
Open

Spring codegen: update and simplify generator logic after recent changes in gapic client generation #2722

zhumin8 opened this issue Mar 19, 2024 · 1 comment
Assignees
@zhumin8
Labels
codegen priority: p2 type: process

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Mar 19, 2024 •
edited

For
current logic here grabs googleapis_committish for each module to generate. The generate scripts:

  • looks for the google-cloud-java release tag
  • looks at git history under path of each module/version to generate, find latest relevant change before the release tag
  • Then for each library, use its commit to checkout versioned protos folder to setup bazel rules (here)

After hermetic build implementation, the monorepo generates with the same googleapis commit (config). This generation logic should be simplified.

cc.@burkedavison
@zhumin8
Copy link
Contributor Author

zhumin8 commented Mar 20, 2024

related, currently proto path is inferred from .OwlBot.yaml here.
We should be able to get from "GAPIC Level Config" under hermetic build setup.

@zhumin8 zhumin8 self-assigned this Mar 20, 2024
@zhumin8 zhumin8 mentioned this issue Mar 21, 2024
Merged
zhumin8 added a commit that referenced this issue Mar 26, 2024
@zhumin8
chore: update codegen to use single googleapis commitish. (#2726)
7dfb4de 
First step to solve #2722.
This should be the minimum set of changes to unblock release with hermetic build changes.
Further cleanup are needed to simplify this workflow. Will raise separate pr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhumin8 zhumin8

Labels
codegen priority: p2 type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhumin8