From 96ea46f69b4a16d303ede06d71b283eb4f44ac28 Mon Sep 17 00:00:00 2001 From: Koichi Shiraishi Date: Sun, 30 Oct 2022 09:39:44 +0900 Subject: [PATCH] exporter/trace: more readable to if else condition Signed-off-by: Koichi Shiraishi --- exporter/trace/trace_proto.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/exporter/trace/trace_proto.go b/exporter/trace/trace_proto.go index 23fc9f2c8..39691fd32 100644 --- a/exporter/trace/trace_proto.go +++ b/exporter/trace/trace_proto.go @@ -157,13 +157,14 @@ func (e *traceExporter) protoFromReadOnlySpan(s sdktrace.ReadOnlySpan) (*tracepb if s.Parent().SpanID() != s.SpanContext().SpanID() && s.Parent().SpanID().IsValid() { sp.ParentSpanId = s.Parent().SpanID().String() } - if s.Status().Code == codes.Ok { + switch s.Status().Code { + case codes.Ok: sp.Status = &statuspb.Status{Code: int32(codepb.Code_OK)} - } else if s.Status().Code == codes.Unset { + case codes.Unset: // Don't set status code. - } else if s.Status().Code == codes.Error { + case codes.Error: sp.Status = &statuspb.Status{Code: int32(codepb.Code_UNKNOWN), Message: s.Status().Description} - } else { + default: sp.Status = &statuspb.Status{Code: int32(codepb.Code_UNKNOWN)} }