Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix propagator package in release.go #540

Merged
merged 1 commit into from Nov 29, 2022

Conversation

damemi
Copy link
Member

@damemi damemi commented Nov 29, 2022

Got a little hot on the merge button in #539 and didn't notice the weird changes in https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/539/files#diff-5e69ba298fd881f2cf26d39a12cf8ac7f4df5900cb66971179941ad33582f93e

Luckily, make release failed with the following:

go run tools/release.go prepare
go: errors parsing example/trace/http/go.mod:
example/trace/http/go.mod:17:2: require github.com/GoogleCloudPlatform/opentelemetry-operations-go/propagator: version "v" invalid: must be of the form v1.2.3
2022/11/29 16:25:36 running "/usr/lib/google-golang/bin/go mod edit -require=github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping@v0.34.2 example/trace/http/go.mod": exit status 1
exit status 1
make: *** [Makefile:207: prepare-release] Error 1

I don't know exactly how adding the / fixes this, but I noticed the other modules all had a trailing slash so I assume there is some text manipulation in the script that depends on it.

@damemi damemi requested a review from dashpole November 29, 2022 16:42
@damemi damemi merged commit 9364351 into GoogleCloudPlatform:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants