Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update OTel dependencies #538

Merged
merged 1 commit into from Nov 29, 2022

Conversation

dmitryax
Copy link
Contributor

And adopt code to the collector API changes

@dmitryax dmitryax force-pushed the update-collector-core branch 2 times, most recently from 8c58964 to b4da594 Compare November 28, 2022 17:33
@dmitryax dmitryax changed the title [chore] Update OTel collector dependency [chore] Update OTel dependencies Nov 28, 2022
@damemi
Copy link
Member

damemi commented Nov 28, 2022

/gcbrun

@damemi
Copy link
Member

damemi commented Nov 28, 2022

@dmitryax can you run make fixtures?

Copy link
Member

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(needs test fixture update)

And adopt to the OTel collector API changes
@dmitryax
Copy link
Contributor Author

@dmitryax can you run make fixtures?

Done 👍

@damemi
Copy link
Member

damemi commented Nov 28, 2022

/gcbrun

@dmitryax
Copy link
Contributor Author

@damemi looks like the e2e failures are the same as in #537. Are they flaky? Can be ignored?

@damemi
Copy link
Member

damemi commented Nov 28, 2022

@dmitryax good question, I was trying to look into that. @dashpole do you have any idea about the e2e failures? Looks like it's having trouble on the google cloud end:

=== RUN   TestBasicTrace
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:85: 
        	Error Trace:	trace_test.go:85
        	            				trace_test.go:106
        	Error:      	Received unexpected error:
        	            	retryable: googleapi: Error 404: Requested entity was not found., notFound
        	Test:       	TestBasicTrace
--- FAIL: TestBasicTrace (13.00s)
=== RUN   TestResourceDetectionTrace
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
=== RUN   TestResourceDetectionTrace/Span_has_label_g.co/agent
=== RUN   TestResourceDetectionTrace/Span_has_label_test_id
=== RUN   TestResourceDetectionTrace/Span_has_label_g.co/r/gce_instance/zone
=== RUN   TestResourceDetectionTrace/Span_has_label_g.co/r/gce_instance/instance_id
--- PASS: TestResourceDetectionTrace (3.29s)
    --- PASS: TestResourceDetectionTrace/Span_has_label_g.co/agent (0.00s)
    --- PASS: TestResourceDetectionTrace/Span_has_label_test_id (0.00s)
    --- PASS: TestResourceDetectionTrace/Span_has_label_g.co/r/gce_instance/zone (0.00s)
    --- PASS: TestResourceDetectionTrace/Span_has_label_g.co/r/gce_instance/instance_id (0.00s)
=== RUN   TestComplexTrace
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:80: Retrying GetTrace: googleapi: Error 404: Requested entity was not found., notFound
    trace_test.go:85: 
        	Error Trace:	trace_test.go:85
        	            				trace_test.go:278
        	Error:      	Received unexpected error:
        	            	retryable: googleapi: Error 404: Requested entity was not found., notFound
        	Test:       	TestComplexTrace
--- FAIL: TestComplexTrace (13.90s)

@dashpole
Copy link
Contributor

Are there any logs from the test server? Did it successfully write the span it is complaining about not finding?

@bogdandrutu
Copy link
Collaborator

@damemi @dashpole can you please help us unblock the last standing PR for pdata stability :)

@damemi damemi merged commit 89bda20 into GoogleCloudPlatform:main Nov 29, 2022
@dmitryax dmitryax deleted the update-collector-core branch December 2, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants