Drop histogram metrics with no non-zero bucket values #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
commented
Nov 18, 2022
| @@ -657,7 +657,7 @@ func (m *metricMapper) histogramToTimeSeries( | |||
| point pmetric.HistogramDataPoint, | |||
| projectID string, | |||
| ) []*monitoringpb.TimeSeries { | |||
| if point.Flags().NoRecordedValue() || !point.HasSum() { | |||
| if point.Flags().NoRecordedValue() || !point.HasSum() || point.ExplicitBounds().Len() == 0 { | |||
There was a problem hiding this comment.
this change affected the _expected test fixture:
diff --git a/exporter/collector/integrationtest/testdata/fixtures/metrics/prometheus_empty_buckets_expected.json b/exporter/collector/integrationtest/testdata/fixtures/metrics/prometheus_empty_buckets_expected.json
index 6633318..96c3f83 100644
--- a/exporter/collector/integrationtest/testdata/fixtures/metrics/prometheus_empty_buckets_expected.json
+++ b/exporter/collector/integrationtest/testdata/fixtures/metrics/prometheus_empty_buckets_expected.json
@@ -3,44 +3,6 @@
{
"name": "projects/fakeprojectid",
"timeSeries": [
- {
- "metric": {
- "type": "workload.googleapis.com/kv_prober_write_latency",
- "labels": {
- "service_instance_id": "0.0.0.0:2112",
- "service_name": "otel-collector"
- }
- },
- "resource": {
- "type": "generic_task",
- "labels": {
- "job": "otel-collector",
- "location": "global",
- "namespace": "",
- "task_id": "0.0.0.0:2112"
- }
- },
- "metricKind": "CUMULATIVE",
- "valueType": "DISTRIBUTION",
- "points": [
- {
- "interval": {
- "endTime": "1970-01-01T00:00:00Z",
- "startTime": "1970-01-01T00:00:00Z"
- },
- "value": {
- "distributionValue": {
- "bucketOptions": {
- "explicitBuckets": {}
- },
- "bucketCounts": [
- "0"
- ]
- }
- }
- }
- ]
- },
There was a problem hiding this comment.
Thats interesting. How were integration tests passing before if there was an invalid histogram?
There was a problem hiding this comment.
Sorry, this wasn't a test that existed before. I added it, and did a before and after with the logic change to see that the (new) fixture was updated.
damemi
force-pushed
the
drop-inf-metrics
branch
from
ecadec9
to
e31b082
Compare
dashpole
reviewed
Nov 21, 2022
damemi
force-pushed
the
drop-inf-metrics
branch
from
e31b082
to
7b261a7
Compare
dashpole
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #525 by dropping metric points that have no bucket bounds, consistent with GMP.
Testdata was generated with the following sample metric:
served on a local endpoint, scraped with the collector's prometheus receiver, and written with the file exporter.