Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterRole in stackdriver adapter has namespace defined #492

Open
5imun opened this issue Nov 9, 2022 · 0 comments · May be fixed by #496
Open

ClusterRole in stackdriver adapter has namespace defined #492

5imun opened this issue Nov 9, 2022 · 0 comments · May be fixed by #496

Comments

@5imun
Copy link

5imun commented Nov 9, 2022

In file adapter_new_resource_model.yaml on line 44 namespace property is defined in the metadata of the ClusterRole.

From the official documentation:

ClusterRole, by contrast, is a non-namespaced resource. The resources have different names (Role and ClusterRole) because a Kubernetes object always has to be either namespaced or not namespaced; it can't be both.

I noticed this problem because my terraform apply was failing with the logs:

Error: Cluster level resource cannot take namespace
with kubernetes_manifest.stackdriver["ClusterRole/custom-metrics-resource-reader"]
Resources of type 'rbac.authorization.k8s.io/v1, Kind=ClusterRole' cannot have a namespace

Here is the relevant commit when namespace was added to the ClusterRole

@ajayk ajayk linked a pull request Nov 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant