From cf5ca01616574c7c04954b5dbb147d0e546d1a0b Mon Sep 17 00:00:00 2001 From: minherz Date: Wed, 13 Sep 2023 11:15:47 -0700 Subject: [PATCH] fix: refactor error reporting code sample align code sample for error reporting with code in other languages. use an explicit error with the "fixed" message --- .../errorreporting_quickstart/main.go | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/errorreporting/errorreporting_quickstart/main.go b/errorreporting/errorreporting_quickstart/main.go index 9eb9ae7110..3b0c4735b8 100644 --- a/errorreporting/errorreporting_quickstart/main.go +++ b/errorreporting/errorreporting_quickstart/main.go @@ -21,8 +21,9 @@ package main import ( "context" + "errors" "log" - "net/http" + "os" "cloud.google.com/go/errorreporting" ) @@ -32,14 +33,18 @@ var errorClient *errorreporting.Client func main() { ctx := context.Background() - // Sets your Google Cloud Platform project ID. - projectID := "YOUR_PROJECT_ID" + // TODO: Sets your Google Cloud Platform project ID via environment or explicitly + projectID := os.Getenv("GOOGLE_PROJECT_ID") + if projectID == "" { + projectID = "YOUR_PROJECT_ID" + } var err error errorClient, err = errorreporting.NewClient(ctx, projectID, errorreporting.Config{ - ServiceName: "myservice", + ServiceName: "errorreporting_quickstart", + ServiceVersion: "0.0.0", OnError: func(err error) { - log.Printf("Could not log error: %v", err) + log.Printf("Could not repport the error: %v", err) }, }) if err != nil { @@ -47,15 +52,15 @@ func main() { } defer errorClient.Close() - resp, err := http.Get("not-a-valid-url") + err = errors.New("Something went wrong") if err != nil { logAndPrintError(err) return } - log.Print(resp.Status) } func logAndPrintError(err error) { + // error context is autopopulated errorClient.Report(errorreporting.Entry{ Error: err, })