Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable: Snippets project should be updated to latest Bigtable client library. #992

Open
amanda-tarafa opened this issue Mar 26, 2020 · 4 comments
Open

Bigtable: Snippets project should be updated to latest Bigtable client library. #992

amanda-tarafa opened this issue Mar 26, 2020 · 4 comments
Labels
api: bigtable Issues related to the Bigtable API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@amanda-tarafa
Copy link
Member

All .NET client libraries have taken a major version bump recently, including Google.Cloud.Bigtable.V2, which includes breaking changes.
I'm currently updating most sample projects except for the ones that need significant rework because of the major version bump (#988 ).
Bigtable.Snippets does need some significant rework around the use of Google.Cloud.Bigtable.V2.ReadRowsStream and IAsyncEnumerable. Basically, the stream received in the filtering method needs to be iterated over in an async manner (this is the efficient way to do it and the one we should be showcasing for our clients) and hence all the samples needs to be reworked as async.

Happy to help if needed.
@amanda-tarafa amanda-tarafa added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigtable Issues related to the Bigtable API. labels Mar 26, 2020
@amanda-tarafa amanda-tarafa added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Apr 2, 2020
@laljikanjareeya
Copy link
Contributor

@billyjacobson I have started working on this, let me know if you are already working on it.

@laljikanjareeya laljikanjareeya self-assigned this Apr 15, 2020
@billyjacobson
Copy link
Member

billyjacobson commented Apr 16, 2020 via email

@laljikanjareeya laljikanjareeya mentioned this issue Apr 20, 2020
Closed
@laljikanjareeya laljikanjareeya mentioned this issue Jul 6, 2020
Closed
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 28, 2020
@amanda-tarafa
Copy link
Member Author

#1121 is addressing this

This was referenced Aug 6, 2021
Closed
Closed
amanda-tarafa added a commit to amanda-tarafa/dotnet-docs-samples that referenced this issue Aug 9, 2021
@amanda-tarafa
build: Ignore dependecy updates for apps that need modernization.
ae10462 
- GoogleCloudPlatform#992 tracks Bigtable samples modernization.
- GoogleCloudPlatform#1004 tracks AppEngine samples modernization.
- GoogleCloudPlatform#1426 tracks Endpoints samples modernizaton.
- GoogleCloudPlatform#1427 trackes Google Home samples modernization.

Closes GoogleCloudPlatform#1434
Closes GoogleCloudPlatform#1430
@amanda-tarafa amanda-tarafa mentioned this issue Aug 9, 2021
Merged
amanda-tarafa added a commit that referenced this issue Aug 9, 2021
@amanda-tarafa
build: Ignore dependecy updates for apps that need modernization.
621fc46 
- #992 tracks Bigtable samples modernization.
- #1004 tracks AppEngine samples modernization.
- #1426 tracks Endpoints samples modernizaton.
- #1427 trackes Google Home samples modernization.

Closes #1434
Closes #1430
amanda-tarafa added a commit to amanda-tarafa/dotnet-docs-samples that referenced this issue Jun 7, 2022
@amanda-tarafa
tests: Skip Bigtable samples tests as dependencies are now too old.
3070e53 
See GoogleCloudPlatform#992
@amanda-tarafa amanda-tarafa mentioned this issue Jun 7, 2022
Merged
amanda-tarafa added a commit to amanda-tarafa/dotnet-docs-samples that referenced this issue Jun 7, 2022
@amanda-tarafa
tests: Skip Bigtable samples tests as dependencies are now too old.
eb735bf 
See GoogleCloudPlatform#992
amanda-tarafa added a commit that referenced this issue Jun 7, 2022
@amanda-tarafa
tests: Skip Bigtable samples tests as dependencies are now too old.
396739b 
See #992
@meredithslota meredithslota assigned Rishabh-V and unassigned shivgautam Mar 9, 2023
@meredithslota
Copy link
Contributor

Linked PR is assigned to @Rishabh-V so updating assignee here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
7 participants
@meredithslota @billyjacobson @amanda-tarafa @Rishabh-V @laljikanjareeya @shivgautam and others