Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger: Modernize application and update dependencies #1426

Open
amanda-tarafa opened this issue Aug 6, 2021 · 5 comments
Open

Swagger: Modernize application and update dependencies #1426

amanda-tarafa opened this issue Aug 6, 2021 · 5 comments
Assignees
@iennae
Labels
api: endpoints Issues related to the Cloud Endpoints API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@amanda-tarafa
Copy link
Member

This sample code seems to be really outdated. Code changes are needed to bring it up to date. But that just makes sense if this samples is still relevant which I don't have the context to know.

@SurferJeffAtGoogle and @simonz130, you seem to have been the main contributors to this sample in the past. Can you give more context as to whether this sample is still being used or not, etc.?
@amanda-tarafa amanda-tarafa added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. api: endpoints Issues related to the Cloud Endpoints API. labels Aug 6, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 6, 2021
This was referenced Aug 6, 2021
Closed
Closed
Closed
amanda-tarafa added a commit to amanda-tarafa/dotnet-docs-samples that referenced this issue Aug 9, 2021
@amanda-tarafa
build: Ignore dependecy updates for apps that need modernization.
ae10462 
- GoogleCloudPlatform#992 tracks Bigtable samples modernization.
- GoogleCloudPlatform#1004 tracks AppEngine samples modernization.
- GoogleCloudPlatform#1426 tracks Endpoints samples modernizaton.
- GoogleCloudPlatform#1427 trackes Google Home samples modernization.

Closes GoogleCloudPlatform#1434
Closes GoogleCloudPlatform#1430
@amanda-tarafa amanda-tarafa mentioned this issue Aug 9, 2021
Merged
amanda-tarafa added a commit that referenced this issue Aug 9, 2021
@amanda-tarafa
build: Ignore dependecy updates for apps that need modernization.
621fc46 
- #992 tracks Bigtable samples modernization.
- #1004 tracks AppEngine samples modernization.
- #1426 tracks Endpoints samples modernizaton.
- #1427 trackes Google Home samples modernization.

Closes #1434
Closes #1430
@SurferJeffAtGoogle
Copy link
Contributor

This sample code seems to be really outdated.

Which code?

@simonz130 simonz130 removed their assignment Apr 19, 2022
@amanda-tarafa
Copy link
Member Author

This one here: https://github.com/GoogleCloudPlatform/dotnet-docs-samples/tree/main/endpoints/getting-started

@SurferJeffAtGoogle
Copy link
Contributor

I don't think so. I recommend removing the sample.

@amanda-tarafa
Copy link
Member Author

Hmmm, the code is actually being used here: https://cloud.google.com/endpoints/docs/openapi/get-started-app-engine-dotnet
The link is both offered as the sample to download and there are a few snippets from the yaml file included in the doc.

I'll try to find an owner for this.

@amanda-tarafa
Copy link
Member Author

@iennae when you are ready for this, do loop me in and I can help with the .NET bits. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iennae iennae

Labels
api: endpoints Issues related to the Cloud Endpoints API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@iennae @SurferJeffAtGoogle @amanda-tarafa @simonz130 and others