Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tedious sample config contains extraneous properties #132

Open
ruyadorno opened this issue May 25, 2023 · 1 comment
Open

Tedious sample config contains extraneous properties #132

ruyadorno opened this issue May 25, 2023 · 1 comment
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@ruyadorno
Copy link
Contributor

Bug Description

In the current README sample and in tedious related system tests there are two properties: server and port that should not be necessary.

Example code (or command)

These properties should not be required:

const clientOpts = await connector.getTediousOptions({
  instanceConnectionName: process.env.SQLSERVER_CONNECTION_NAME,
  ipType: 'PUBLIC'
});
const connection = new Connection({
-  server: '0.0.0.0',
  authentication: {
    type: 'default',
    options: {
      userName: process.env.SQLSERVER_USER,
      password: process.env.SQLSERVER_PASS,
    },
  },
  options: {
    ...clientOpts,
-    port: 9999,
    database: process.env.SQLSERVER_DB,
  },
})

More Info

Currently this properties are required due to a bug in the tedious driver itself that still tries to validate these properties even when the user is defining a custom connector factory method.

Related bug in Tedious: tediousjs/tedious#1541

@ruyadorno ruyadorno added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 25, 2023
@ruyadorno
Copy link
Contributor Author

Related PR to fix the issue in tedious: tediousjs/tedious#1542

@enocom enocom added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

3 participants