Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e tests to be sample friendly #792

Open
jackwotherspoon opened this issue May 7, 2024 · 0 comments
Open

Update e2e tests to be sample friendly #792

jackwotherspoon opened this issue May 7, 2024 · 0 comments
Assignees
@jackwotherspoon
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@jackwotherspoon
Copy link
Collaborator

We should update e2e tests to be similar to AlloyDB Go Connector: https://github.com/GoogleCloudPlatform/alloydb-go-connector/blob/main/e2e_test.go#L71

This format lends itself nicely to copy/paste and can allow us to update our README with permalinks that do not reference test errors such as t.Fatalf()
@jackwotherspoon jackwotherspoon self-assigned this May 7, 2024
@jackwotherspoon jackwotherspoon added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 7, 2024
@jackwotherspoon jackwotherspoon mentioned this issue May 7, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jackwotherspoon