Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate cache on failed IP lookup #780

Closed
enocom opened this issue Apr 26, 2024 · 0 comments · Fixed by #812 · May be fixed by #814
Closed

Invalidate cache on failed IP lookup #780

enocom opened this issue Apr 26, 2024 · 0 comments · Fixed by #812 · May be fixed by #814
Assignees
@enocom
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Apr 26, 2024

In #768, we removed an implicit behavior of the Go Connector. If a dial attempt requests a non-existent IP type (e.g., client asks for public IP on a private IP only instance), the Connector would invalidate the cache. But with the cleanup PR, we removed that implicit behavior.

In some cases, it might be useful to have this behavior. For example, if a caller starts the Go Connector and tries to connect to a public IP and then later configures public IP, there is no need for a restart.

We made that change in the AlloyDB Go Connector mostly because some internal tests depend on that behavior. See GoogleCloudPlatform/alloydb-go-connector#555.

This is for porting the same behavior here.
@enocom enocom added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 26, 2024
enocom added a commit that referenced this issue May 27, 2024
@enocom
feat: invalidate cache on failed IP lookup
573f537 
In #768, we removed an implicit behavior of the Go Connector. If a dial
attempt requests a non-existent IP type (e.g., client asks for public IP
on a private IP only instance), the Connector would invalidate the
cache. But with the cleanup PR, we removed that implicit behavior.

In some cases, it might be useful to have this behavior. For example, if
a caller starts the Go Connector and tries to connect to a public IP and
then later configures public IP, there is no need for a restart.

We made that change in the AlloyDB Go Connector mostly because some
internal tests depend on that behavior. See
GoogleCloudPlatform/alloydb-go-connector#555.

Fixes #780
@enocom enocom mentioned this issue May 28, 2024
Merged
enocom added a commit that referenced this issue May 28, 2024
@enocom
feat: invalidate cache on failed IP lookup (#812)
4b68de3 
In #768, we removed an implicit behavior of the Go Connector. If a dial
attempt requests a non-existent IP type (e.g., client asks for public IP
on a private IP only instance), the Connector would invalidate the
cache. But with the cleanup PR, we removed that implicit behavior.

In some cases, it might be useful to have this behavior. For example, if
a caller starts the Go Connector and tries to connect to a public IP and
then later configures public IP, there is no need for a restart.

We made that change in the AlloyDB Go Connector mostly because some
internal tests depend on that behavior. See
GoogleCloudPlatform/alloydb-go-connector#555.

Fixes #780
@release-please release-please bot mentioned this issue May 28, 2024
Open
@enocom enocom assigned enocom and unassigned jackwotherspoon May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@enocom @jackwotherspoon