Warmup and EngineVersion don't close cache on failed lookup #778
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
EngineVersion doesn't close the cache on error:
cloud-sql-go-connector/dialer.go
Lines 387 to 396 in c4fb69f
Warmup doesn't close the cache on error:
cloud-sql-go-connector/dialer.go
Lines 403 to 412 in c4fb69f
As a result, if a client connects with a bad instance connection name, missing IAM permissions, no network connectivity etc, the background refresh will continue running regardless.
Instead, we should close the cache and delete it from the shared map.
The text was updated successfully, but these errors were encountered: