Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialers using the WithHTTPEndpoint opt don't use the correct Useragent #157

Closed
kurtisvg opened this issue Mar 31, 2022 · 1 comment
Closed

Dialers using the WithHTTPEndpoint opt don't use the correct Useragent #157

kurtisvg opened this issue Mar 31, 2022 · 1 comment
Assignees
@enocom
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kurtisvg
Copy link
Contributor

Likely related to the upstream TODO here: https://github.com/googleapis/google-api-go-client/blob/9d43e7dc08e2598d4dcb661324c4877dfd63c4f9/transport/http/dial.go#L40
@kurtisvg kurtisvg added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 31, 2022
@kurtisvg kurtisvg mentioned this issue Apr 5, 2022
Merged
@enocom enocom added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 26, 2022
@enocom
Copy link
Member

enocom commented Nov 18, 2022

Related to googleapis/google-api-go-client#494.

@enocom enocom closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enocom @kurtisvg