Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable TCK tests #488

Open
7 tasks
elefeint opened this issue Jan 18, 2022 · 0 comments
Open
7 tasks

Re-enable TCK tests #488

elefeint opened this issue Jan 18, 2022 · 0 comments
Assignees
@elefeint
Labels
enhancement New feature or request P2 release-blockers
Milestone
Support R2DBC SPI...

Comments

@elefeint
Copy link
Contributor

elefeint commented Jan 18, 2022 •
edited

I had to disable the whole TCK class temporarily because there are 7 tests failing due to not-yet-implemented functionality.

Remove this line to re-enable.

  • columnMetadata()
  • prepareStatementWithTrailingAddShouldFail
  • segmentInsertWithFilterCompletesWithoutOnNext
  • row
  • segmentInsertEmitsUpdateCount
  • segmentSelectWithEmitsRow
  • segmentSelectWithFilterCompletesWithoutOnNext

Several of the above have to do with implementing the Segment API.
The R2DBC SPI changelog describes all differences from 0.8 SPI to 1.0 SPI, with PR numbers describing each in detail.
@elefeint elefeint mentioned this issue Jan 18, 2022
Merged
elefeint added a commit that referenced this issue Jan 26, 2022
@elefeint
Upgrade SPI and fix blocking errors (#489)
5b4487e 
I've disabled the TCK tests and filed a tracking issue #488 for it. There are still changes in `SpannerClientLibraryTestKit.java` for easy-to-fix failures due to test column being renamed from "value" to "test_value".

The remaining TCK tests are for missing features, but will need to be re-enabled before we can release (for assurance on TCK compliance).
@elefeint elefeint added this to the h2-2022-candidates milestone May 12, 2022
@elefeint elefeint added P2 and removed P1 labels Aug 12, 2022
@elefeint elefeint self-assigned this Aug 12, 2022
@elefeint elefeint added P1 and removed P2 labels Dec 2, 2022
@dangazineu dangazineu added P2 and removed P1 labels Dec 5, 2022
@burkedavison burkedavison mentioned this issue Mar 3, 2023
Merged
@burkedavison burkedavison added the enhancement New feature or request label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elefeint elefeint

Labels
enhancement New feature or request P2 release-blockers
Projects
None yet
Milestone
Support R2DBC SPI 1.0
Development

No branches or pull requests
3 participants
@dangazineu @burkedavison @elefeint