Support existing access token when using UserCredentials auth type #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Credentials auth type
qcastel
commented
Sep 7, 2022
| @@ -341,7 +363,10 @@ private static GoogleCredentials configureCredentials( | |||
| } | |||
| if (credentials instanceof UserCredentials) { | |||
| return ((UserCredentials) credentials) | |||
| .toBuilder().setTokenServerUri(URI.create(tokenServerUrl)).build(); | |||
| .toBuilder() | |||
| .setAccessToken(credentials.getAccessToken()) | |||
There was a problem hiding this comment.
I had to do that, to workaround googleapis/google-auth-library-java#993
medb
changed the title
|
@medb any news on this one? |
|
@medb Whats your view on this one? Want me to close it as wont do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Dataiku, we found a small optimisation of the UserCredentials auth type that we thought we could share with you guys.
Saving a bit of network calls to Google OAuth2 provider.
Fixes #869