Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

Comparison with a production url #31

Open
durancristhian opened this issue May 15, 2018 · 2 comments
Open

Comparison with a production url #31

durancristhian opened this issue May 15, 2018 · 2 comments

Comments

@durancristhian
Copy link

Hi! I found this amazing project and I started to use it a lot 馃槑 thank you so mucho for creating it.

My question is that if it's possible (somehow) to have one of these in the PR commment:

  1. The results of the production website and the stage deploy to compare
  2. The score's difference between a production url and the stage

Do you think that it's possible to have this information?
To be clear, I'm not asking for a feature. I just want to know if someone else have faced this particular case where I'd like a PR to be "rejected" (ask for improvements) when the stage's score is worse than production's score (I know that I can set a flag, but that's fixed, I want to compare with my own implementation).

Hope I was clear enough! 馃槉

@durancristhian
Copy link
Author

Probably I can run the command twice, one with the stage's url and another one with the production url 馃

In that case, due to the form that the results are presented, I wouldn't be able to differentiate which is which.

@daneden
Copy link

daneden commented Apr 6, 2019

Here to +1! I was just about to open an identical issue.

I love the Lighthouse bot but it would be awesome if I could pass an additional URL in the CLI to compare against a real benchmark. Ideally this would add two additional columns to the results table, making the columns:

  • New score
  • Old score (from new production URL parameter)
  • Change
    • Values would be + or - difference between new and old scores
  • Required threshold

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants