Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

Proposal: Add link to the report in the bot comment #11

Open
abdonrd opened this issue Oct 27, 2017 · 7 comments
Open

Proposal: Add link to the report in the bot comment #11

abdonrd opened this issue Oct 27, 2017 · 7 comments

Comments

@abdonrd
Copy link

abdonrd commented Oct 27, 2017

It would be great if the bot comment had a link to the report.

From:

Updated Lighthouse report for the changes in this PR:

Category Score
Progressive Web App 91
Performance 93
Accessibility 100
Best Practices 92

Tested with Lighthouse version: 2.3.0

To:

Updated Lighthouse report for the changes in this PR:

Category Score
Progressive Web App 91
Performance 93
Accessibility 100
Best Practices 92

Tested with Lighthouse version: 2.3.0

@ebidel
Copy link
Contributor

ebidel commented Oct 27, 2017

Good call. Want to send a PR?

@mderazon
Copy link

@ebidel btw, what's the retention policy for these reports ? how long are they going to be available ?

@ebidel
Copy link
Contributor

ebidel commented Dec 12, 2017

There's no guarantees on uptime, retention, or reports being available, long-term. I suggest running your own setup if that's something important to you :)

@balazsorban44
Copy link

Is there any progress on this?

@robinmetral
Copy link

robinmetral commented Aug 23, 2019

@ebidel I'm interested in making a PR for this, but I'd love some insights 🙂

So we can generate the html file by passing output: html:

curl -X POST \
  -H "Content-Type: application/json" \
  -H "X-API-KEY: [secret]" \
  --data '{"output": "html", "url": "https://developers.google.com/web/tools/lighthouse/"}' \
  https://builder-dot-lighthouse-ci.appspot.com/ci

One thing we could do is add a flag in the request to /ci that would only send back the generated fileName (timestamp-based) so we can add the URL to the comment.

This can be done in runLH:

function runLH(params, req, res, next) {

@krzkaczor
Copy link

Hey @robinmetral @balazsorban44 @abdonrd

lighthouse-keeper uploads not only full html reports but also keeps track of how metrics change between PR. You should check it out!

@robinmetral
Copy link

@krzkaczor thanks, I'll take a look! 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants