Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Signing in on the measure page retains the large signin CTA #2272

Closed
samthor opened this issue Mar 3, 2020 · 1 comment · Fixed by #2294
Closed

Signing in on the measure page retains the large signin CTA #2272

samthor opened this issue Mar 3, 2020 · 1 comment · Fixed by #2294
Labels
eng - bug Something broke!

Comments

@samthor
Copy link
Contributor

samthor commented Mar 3, 2020

Describe the bug
When you sign in on https://web.dev/measure, the large "Sign In With Google" button in the middle of the page sticks around until you navigate back/forwards.

Note that signing out where the button is hidden, correctly makes the button visible again.

To Reproduce
Go to measure page, sign in, see button remain, navigate in/out, see that button is hidden.

Expected behavior
Sign in button disappears.

Screenshots
image

@samthor
Copy link
Contributor Author

samthor commented Mar 5, 2020

Returning "" from the render() method in our LitElement subclasses—turns out it was silently not being rendered. This is solved by a recent PR in lit-element but is yet to be released.

I'm sending a PR that replaces our return "";'s with something that returns an empty template, rather than an empty string.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng - bug Something broke!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant