Rename getXXX functions to onXXX #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrabovsky
added a commit
to fedora-ci/ciboard
that referenced
this pull request
Nov 18, 2022
The `getXXX()` functions of the `web-vitals` library were renamed in 3.0.0 to `onXXX()` [1]. Fix our calls to reflect this. [1]: GoogleChrome/web-vitals#222
mgrabovsky
added a commit
to fedora-ci/ciboard
that referenced
this pull request
Nov 18, 2022
The `getXXX()` functions of the `web-vitals` library were renamed in 3.0.0 to `onXXX()` [1]. Fix our calls to reflect this. [1]: GoogleChrome/web-vitals#222
This was referenced Feb 2, 2023
akunzai
added a commit
to akunzai/GSS.Authentication.CAS
that referenced
this pull request
Jul 7, 2023
akunzai
added a commit
to akunzai/react-boilerplate
that referenced
this pull request
Jul 7, 2023
rupesh1
added a commit
to rupesh1/core-web-vitals
that referenced
this pull request
Feb 4, 2024
- to be compatible with future versions of webvitals which will drop `get` following deprecation in GoogleChrome/web-vitals#222 (I'm not sure when this will happen but as we're loading an unversioned copy of webvitals it feels safer to do it sooner)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #217 by renaming all of the
getXXX()functions toonXXX(). It also includes adeprecations.tsfile that aliases these so existing code using the old names won't break (I plan to keep this in for at least 1 major version).While this rename will eventually require some work for any developer upgrading, the change is negligible and I believe the new names make it much clearer that these functions:
Both of these are long-standing points of developer confusion (see #217 for more details), and I think it's worth the small name change to accomodate.