Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp LCP and FCP to 0 for prerendered pages #270

Merged
merged 1 commit into from Oct 18, 2022

Conversation

tunetheweb
Copy link
Member

Fixes #268

Not sure how to add a test for this, since the prerendered test (http://localhost:9090/test/lcp?prerender=1) is just a stub and not an actual preprendered page so LCP is not zero.

@tunetheweb
Copy link
Member Author

Note this will clamp ALL FCP and LCP values, not just prerendered ones. But I'm not sure that's such a bad thing?

Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tunetheweb tunetheweb merged commit c41fed3 into GoogleChrome:main Oct 18, 2022
@tunetheweb tunetheweb deleted the prerender-LCP-FCP branch October 19, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onLCP does not work on prerendered pages
2 participants