Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the INP duration threshold #103

Closed
rviscomi opened this issue May 11, 2022 · 3 comments
Closed

Adjust the INP duration threshold #103

rviscomi opened this issue May 11, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@rviscomi
Copy link
Member

image

INP currently shows as "waiting for input" even after interacting with the page, if the interaction latency is sufficiently small. As a result, we show data for FID, but not INP. This might throw people off, so look into lowering the reporting threshold for INP events in web-vitals.js.

We could lower the default threshold or let developers choose a threshold in the extension options to balance reporting with performance.

cc @philipwalton @mmocny

@mmocny
Copy link
Member

mmocny commented May 12, 2022

Makes sense to me.

Pasting a bit more context here from prior conversations:

  • We may be able to decide if its better to add a config option or just default to 16ms after this issue is resolved.
  • Specifical to "FID shows and INP doesn't" I think it can happen even with 16ms durationThreshold. Maybe we should just address that issue directly. One idea Philip had was to just update web-vitals.js to expose the FID time data as the first INP score. We actually already do expose duration value for first-input and it looks like that includes times <16ms.

There could be value to doing both of the above, the the latter seems easier, more valuable, and less risky.

So, filed GoogleChrome/web-vitals#228

@mmocny
Copy link
Member

mmocny commented Jun 6, 2022

GoogleChrome/web-vitals#228 is fixed and so now first input now always counts as an INP score.

There's more follow-up there chrome-side to change the reporting of FID, but I think if we just update the web-vitals library this issue will get a lot better.

I did also benchmark PO (this issue) and found that the there is no measurable overhead that I could find... but even adding something like a console.log can change to affect perf, and saving state from callbacks can affect things link GC. All that said, probably having DevTools perf panel open is a much larger effect on perf itself than this extension :)

@tunetheweb
Copy link
Member

Looks to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants