Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): make eval test resilient to error format #4793

Merged
merged 1 commit into from Aug 1, 2019

Conversation

yury-s
Copy link
Contributor

@yury-s yury-s commented Aug 1, 2019

Make eval test resilient to variations in error message format between browsers.This will make the test pass without alternations in WebKit as well as Crhrome and Firefox.

@yury-s yury-s changed the title Make eval test resilient to varioations in error message format betwe… fix(tests): Make eval test resilient to varioations in error message format betwe… Aug 1, 2019
@yury-s yury-s changed the title fix(tests): Make eval test resilient to varioations in error message format betwe… fix(tests): make eval test resilient to error format Aug 1, 2019
@aslushnikov aslushnikov merged commit e2db16f into puppeteer:master Aug 1, 2019
@yury-s yury-s deleted the ref-test branch August 16, 2019 16:38
rfojtik pushed a commit to rfojtik/puppeteer that referenced this pull request Dec 21, 2019
Make eval test resilient to variations in error message format between browsers.This will make the test pass without alternations in WebKit as well as Crhrome and Firefox.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants