feat(chromium): roll Chromium to r705776 #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corresponds to Chromium 79.0.3942.0. This roll includes: - Support CSS media feature emulation in CDP https://chromium-review.googlesource.com/c/chromium/src/+/1821608 - Implement timezone ID verification https://chromium-review.googlesource.com/c/chromium/src/+/1822557 - Allow aria-hidden objects into the browser-side ax tree https://chromium-review.googlesource.com/c/chromium/src/+/1760862
r706915 corresponds to 79.0.3945.1.
mathiasbynens
force-pushed
the
roll-chromium-79
branch
from
9472702
to
6c2095d
Compare
mathiasbynens
changed the title
@JoelEinbinder @aslushnikov any ideas on what might be going on here? |
mathiasbynens
force-pushed
the
roll-chromium-79
branch
from
e291716
to
17248e4
Compare
|
The
The CL that jumps out is: https://chromium-review.googlesource.com/c/chromium/src/+/1752244 I've left a comment here: https://bugs.chromium.org/p/chromium/issues/detail?id=989251#c21 |
Per upstream Chromium changes, page.screenshot now clips elements to the viewport. This matches the clipping behavior of elements in inner scrollers (i.e., document and overflow scroll clipping now work the same). https://bugs.chromium.org/p/chromium/issues/detail?id=937609
test/waittask.spec.js
Outdated
| @@ -189,7 +182,8 @@ module.exports.addTests = function({testRunner, expect, product, puppeteer}) { | |||
| await page.evaluate(() => window.__injected = true); | |||
| await watchdog; | |||
| }); | |||
| it('should survive cross-process navigation', async({page, server}) => { | |||
| // https://chromium-review.googlesource.com/c/chromium/src/+/1766001/21#message-a6a61261b97ffca6ecb180c0a2303b538f7a6476 | |||
There was a problem hiding this comment.
I didn't look too closely, but I'd guess you need to catch this new error string in the navigation watcher.
There was a problem hiding this comment.
Thanks for the hint. I think you meant ExecutionContext, and I'll add the check there. Let me know if I misunderstood!
mathiasbynens
force-pushed
the
roll-chromium-79
branch
from
8d6a898
to
9abf607
Compare
mathiasbynens
force-pushed
the
roll-chromium-79
branch
from
9abf607
to
648f63d
Compare
mathiasbynens
added a commit
that referenced
this pull request
Oct 23, 2019
This corresponds to Chromium 79.0.3942.0. This roll includes: - Support CSS media feature emulation in CDP https://chromium-review.googlesource.com/c/chromium/src/+/1821608 - Implement timezone ID verification https://chromium-review.googlesource.com/c/chromium/src/+/1822557 - Allow aria-hidden objects into the browser-side ax tree https://chromium-review.googlesource.com/c/chromium/src/+/1760862 - Remove pre-BlinkGenPropertyTrees codepaths (affects screenshot clipping) https://chromium-review.googlesource.com/c/chromium/src/+/1752244 - Terminate some asynchronous waiting commands on cross-process navigation https://chromium-review.googlesource.com/c/chromium/src/+/1766001/21#message-a6a61261b97ffca6ecb180c0a2303b538f7a6476 Per upstream Chromium changes, `page.screenshot` now clips elements to the viewport. This matches the clipping behavior of elements in inner scrollers (i.e., document and overflow scroll clipping now work the same).
|
Was this supposed to be merged? It just says WIP. |
Yes. The WIP comment is from earlier this week. For context, this roll was blocking several outstanding PRs + the new v2.0.0 release. |
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
This corresponds to Chromium 79.0.3942.0. This roll includes: - Support CSS media feature emulation in CDP https://chromium-review.googlesource.com/c/chromium/src/+/1821608 - Implement timezone ID verification https://chromium-review.googlesource.com/c/chromium/src/+/1822557 - Allow aria-hidden objects into the browser-side ax tree https://chromium-review.googlesource.com/c/chromium/src/+/1760862 - Remove pre-BlinkGenPropertyTrees codepaths (affects screenshot clipping) https://chromium-review.googlesource.com/c/chromium/src/+/1752244 - Terminate some asynchronous waiting commands on cross-process navigation https://chromium-review.googlesource.com/c/chromium/src/+/1766001/21#message-a6a61261b97ffca6ecb180c0a2303b538f7a6476 Per upstream Chromium changes, `page.screenshot` now clips elements to the viewport. This matches the clipping behavior of elements in inner scrollers (i.e., document and overflow scroll clipping now work the same).
This was referenced Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP