chore: drop Node.js v6 support #5045
Conversation
Node6 was end-of-life'ed in the end of April, 2019, with AWS Lambda prohibiting updaets to the node6 runtime since June 30, 2019. This makes it quite safe for us to remove the Node 6 support from the repository. From now on, all the subsequent commits will require Node 8.9.0+.
Merge branch 'bye-node-6' of https://github.com/aslushnikov/puppeteer into aslushnikov-bye-node-6 * 'bye-node-6' of https://github.com/aslushnikov/puppeteer: Remove supportsAsyncAwait chore: drop Node6 support
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the 鈩癸笍 Googlers: Go here for more info. |
This shouldn't affect its flakiness.
mathiasbynens
force-pushed
the
aslushnikov-bye-node-6
branch
2 times, most recently
from
f835a1d
to
9cf5335
Compare
mathiasbynens
force-pushed
the
aslushnikov-bye-node-6
branch
3 times, most recently
from
85b577a
to
1810233
Compare
We can reconsider this once browserify/browserify#1844 gets merged.
mathiasbynens
force-pushed
the
aslushnikov-bye-node-6
branch
from
1810233
to
38a2dea
Compare
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) 鈩癸笍 Googlers: Go here for more info. |
See this for details: puppeteer/puppeteer#5045
Node.js v6 was end-of-life'd in April, 2019, with AWS Lambda prohibiting updaets to the Node.js v6 runtime since June 30, 2019. This makes it quite safe for us to remove the Node 6 support from the repository.
As discussed offline, I'll be taking @aslushnikov's PR from #4654 and (hopefully!) bring it across the finish line. 馃憤