docs(contributing): mention manual docs/api updates #5023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My two cents here. I commented this on #5015 This was being done as part of step 4 ´ Source Code: mark post-release´.
It's not it should be in that way. It's just how it was being done in the past. |
|
Thanks for pointing that out, @kblok. Doing it the way this patch proposes means the README on npm will also have the new version included, which seems strictly better. |
mathiasbynens
deleted the
update-contributing-releases-per-chromium-version
branch
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
This was referenced Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #5015.