feat(api): add page.emulateMedia{Type,Features} #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeurer
reviewed
Oct 7, 2019
mathiasbynens
force-pushed
the
emulate-css-media-features
branch
2 times, most recently
from
22e861c
to
b9a3db1
Compare
Closed
mathiasbynens
force-pushed
the
emulate-css-media-features
branch
from
b9a3db1
to
2d0264d
Compare
|
Added the old |
mathiasbynens
force-pushed
the
emulate-css-media-features
branch
from
dfd6572
to
5ee8e84
Compare
mathiasbynens
force-pushed
the
emulate-css-media-features
branch
from
5ee8e84
to
62e4265
Compare
mathiasbynens
force-pushed
the
emulate-css-media-features
branch
from
2939ab0
to
cf791f4
Compare
|
Comment on lines
+1302
to
+1312
| await page.emulateMediaFeatures([{ name: 'prefers-reduced-motion', value: 'reduce' }]); | ||
| await page.evaluate(() => matchMedia('(prefers-reduced-motion: reduce)').matches)); | ||
| // → true | ||
| await page.evaluate(() => matchMedia('(prefers-color-scheme: no-preference)').matches)); | ||
| // → false | ||
|
|
||
| await page.emulateMediaFeatures([{ name: 'prefers-reduced-motion', value: 'reduce' }]); | ||
| await page.evaluate(() => matchMedia('(prefers-reduced-motion: reduce)').matches)); | ||
| // → true | ||
| await page.evaluate(() => matchMedia('(prefers-color-scheme: no-preference)').matches)); | ||
| // → false |
There was a problem hiding this comment.
It seems these blocks are duplicate.
There was a problem hiding this comment.
@vsemozhetbyt Wanna submit a patch?
There was a problem hiding this comment.
Hope it's right: #5072
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
This was referenced Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is just to illustrate what the API could look like. The goal is to get feedback and iterate on the approach.
CDP supports emulating CSS media features (e.g.
prefers-color-scheme,prefers-reduced-motion) in addition to media types (e.g.screen,print) as of Chromium v79.0.3929.0+.An open question is, how do we expose this functionality as a Puppeteer API? IMHO, there's two main options:
page.emulateMediaType(type)), and one for media features:page.emulateMediaFeatures(features)page.emulateMedia(typeOrFeatures)This PR implements the first option, which feels cleanest to me. Note that in this WIP PR,
page.emulateMedia(mediaType)has been renamed topage.emulateMediaType(type)(a breaking change!) to make the distinction between the two APIs more clear. We could of course decide to keep the old API for the time being as an alias.Thoughts?
Ref. #4906.
Blocked on a Chromium roll to v79.0.3929.0 (r701361).