Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors running Page.getResourceTree in DevTools e2e tests #14662

Closed
adamraine opened this issue Jan 11, 2023 · 2 comments · Fixed by #14782
Closed

Errors running Page.getResourceTree in DevTools e2e tests #14662

adamraine opened this issue Jan 11, 2023 · 2 comments · Fixed by #14782
Assignees
Labels
DevTools P2 test backlog disabled or needed tests

Comments

@adamraine
Copy link
Member

adamraine commented Jan 11, 2023

Examples:
https://github.com/GoogleChrome/lighthouse/actions/runs/3886546524/jobs/6632091706
https://github.com/GoogleChrome/lighthouse/actions/runs/3887332794/jobs/6633815689

This only happens for legacy navigation. I also can't reproduce this outside of the DevTools e2e tests or on e2e tests locally.

These are the only places where Page.getResourceTree is called. We only call it to get the main frame id:

const resourceTreeResponse = await this._session.sendCommand('Page.getResourceTree');

const resourceTreeResponse = await this._session.sendCommand('Page.getResourceTree');

Perhaps we can avoid the error by getting the frame id using a different method.

Related:
#14660

@adamraine adamraine added DevTools P2 test backlog disabled or needed tests labels Jan 11, 2023
@adamraine adamraine self-assigned this Jan 11, 2023
@adamraine
Copy link
Member Author

I think I'm going to try replacing calls to Page.getResourceTree with Page.getFrameTree to get the main frame id. If the error persists I'll try tracking the main frame id via Page.frameNavigated events which we are already tracking in both files.

@adamraine
Copy link
Member Author

Haven't seen this since #14663, I'm gonna close but will keep an eye out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevTools P2 test backlog disabled or needed tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant