core(network-requests): include starting timestamp as debug data #14253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
connorjclark,
alexnj and
a team
and removed request for
a team
alexnj
approved these changes
Aug 1, 2022
brendankenny
added a commit
that referenced
this pull request
Aug 2, 2022
brendankenny
added a commit
that referenced
this pull request
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #14252, this allows comparing two hidden debug audits with slightly different time origins.
The
network-requestshidden audit uses the first network request start time as time zero, and emits all network timestamps relative to that point in the LHR.This is fine for most purposes, unless you want to compare network request times to metric timestamps, which use navStart as a time origin. navStart and the first networkRequest are usually very close (a few milliseconds...trace events are
navigationStartand the followingResourceWillSendRequestwith the samerequestIdas the navStart'snavigationId), but not simultaneous.Rather than add the trace as a required artifact to the
network-requestsaudit (complicating it and increasing the chances the audit will error or not be able to run), this PR just adds the raw request timestamp to the debugData since this is primarily for debugging. When comparing to e.g.observedLargestContentfulPaintAllFramesTsover in metrics, this base timestamp can be added to the network requests startTimes and the numbers can be compared directly.