New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the sidebar fill the vertical space. #3864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would you mind including a screenshot after the change?
Also Playwright Tests need to be regenerated |
@dlaliberte, this change shifts the |
Answered in chat earlier, but here is a bit more detail. The top part of the dialog popup (dropdown) is covered by the mask, and it would be better to arrange that this didn't happen, somehow, if not too difficult. Perhaps by scrolling the window content, resizing the window, or creating the mask in a way that is below the dialog. Or maybe the screenshot could just focus on the popup element. Not a big deal in any event. |
Also remove a margin-top from the footer that was creating a gap with the sidebar in short windows. Then the footer's shadow disappeared because the z-index was being ignored, which required adding a position property. It's possible we'll want the content-flex-wrapper to include some padding so things don't run right up to the footer, but nothing I've tested looks particularly bad.
Expanding the incubation section moved the history section far enough away that its mask doesn't cover the OT dialog. Thanks for the reviews; I'll merge after the tests pass. |
Also remove a
margin-top
from the footer that was creating a gap with the sidebar in short windows. Then the footer's shadow disappeared because thez-index
was being ignored, which required adding aposition
property. It's possible we'll want the#content-flex-wrapper
to include some padding so things don't run right up to the footer, but nothing I've tested looks particularly bad.Fixes #3852.
Most of the changed lines are unindenting a block after removing one
<div>
layer: look at the diff without whitespace changes.