Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated Votes, Comments, Progress, Process API calls in feature-detail page #3776

Open
KyleJu opened this issue Apr 4, 2024 · 1 comment
Labels

Comments

@KyleJu
Copy link
Collaborator

KyleJu commented Apr 4, 2024

Describe the bug
There are repeated Votes, Comments, Progress, Process API calls in feature-detail page. These data are fetched when user visits feature page, and fetched again when user opens each gate

Screenshot 2024-04-04 at 7 56 57 AM

To Reproduce
Steps to reproduce the behavior:

  1. Open chrome dev tools
  2. Go to a random feature
  3. Check API calls for Votes, Comments, Progress, Process
  4. Click on a gate chip, these APIs are called again.

Expected behavior
These data should be passed in from the feature to the gate chip class, rather than fetch it every time.

Additional context
Small speed-up

@KyleJu KyleJu added the bug label Apr 4, 2024
@jrobbins
Copy link
Collaborator

jrobbins commented Apr 4, 2024

I think we need a strategy to update page content in real time as other users make changes. E.g., if two of the API owners are in a meeting talking about approving an intent, and one of them votes, the other one should see that vote without having to reload the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants