New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Somehow I was able to give 2 LGTMs as an API Owner #3692
Comments
I have a lead on this bug. Your message to blink-dev listed The two emails were processed by ChromeStatus a second apart. If it is a race condition, we probably need to specify a read-consistency parameter on our datastore query, or it might be just failure to check for an existing vote. I'll try to fix it now. |
Actually, the tasks finished 1 second apart, but the two votes were written to datastore just 4ms apart. So, this seems like a straight race condition. We already use strong read consistency. I'll brainstorm with my team on what other ways we can avoid this problem. |
Actually, the tasks started almost exactly 1 second apart. That is consistently what I see when I try to repro the problem on our staging server. That 1s separation is because we specify a rate of 1/s in queues.yaml. So, the first task started, it somehow got delayed for exactly 1s, and then it got into a race with the second task. From the logs:
This is a race condition, but because of the 1/s rate limit, I think it is not very likely to happen. In fact, I failed to repro the problem. |
I deleted the duplicate vote on that review gate. |
https://chromestatus.com/feature/5189728691290112
Probably related, I have no memories of actually using the Chrome Status tool to give these LGTMs, and they don't show up in the comments log.
The text was updated successfully, but these errors were encountered: