Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing API Owners gate for "Write up motivation" stage #3649

Open
jrobbins opened this issue Feb 6, 2024 · 0 comments
Open

Missing API Owners gate for "Write up motivation" stage #3649

jrobbins opened this issue Feb 6, 2024 · 0 comments
Assignees
Labels

Comments

@jrobbins
Copy link
Collaborator

jrobbins commented Feb 6, 2024

According to launching-features, feature owners are supposed to send an "Intent to deprecate" during the "Write up motivation" stage and get 3 LGTMs for it. I think that we completely missed this when we added all the cross functional review gates.

Also, in detect_intent.py, the "Intent to deprecate" subject line is detected, and it is currently ignored because of the missing gate. Once we add the gate, we should check that the detected intent is actually processed rather than being ignored like "intent to prototype" threads.

@jrobbins jrobbins added the bug label Feb 6, 2024
@jrobbins jrobbins self-assigned this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant