Skip to content

Update typescript & types #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2020
Merged

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented May 16, 2020

Latest TypeScript is more accurate, faster, and mathematically higher 🥳

I also updated @types/rimraf, and @types/sinon: while this is bumping majors, it's raising them to match the current version of the package in use, as @types packages match the major.minor version of the package their typing (i.e so @types/sinon@9 should be used for sinon@9, while @types/sinon@7 should be used for sinon@7)

This revealed that the this.timeout = assignment being done in a test was invalid (since arrow functions don't have access to the mocha context); it's actually not needed because the timeout is set higher than 3500 via the launching flag.

@G-Rath
Copy link
Contributor Author

G-Rath commented May 16, 2020

@patrickhulce I've opened up two minor PRs for now, because I don't want to tornado through your project tearing things up and stepping on toes but I'm keen to go further if you'd like (and if that works for the GoogleChrome org?), namely by enabling strict mode.

I did also notice that the type-check command is currently only checking js files, and doesn't use the same settings as your tsconfig - I'm happy to tweak that as well if you'd like 🙂

@G-Rath G-Rath force-pushed the update-typescript branch from 8e3435a to 95c4cc5 Compare May 16, 2020 00:46
@G-Rath G-Rath changed the title Update typescript Update typescript & types May 16, 2020
@G-Rath G-Rath force-pushed the update-typescript branch from 95c4cc5 to f6a42ac Compare May 16, 2020 00:51
@patrickhulce patrickhulce merged commit d915429 into GoogleChrome:master May 16, 2020
@paulirish
Copy link
Member

published in 0.13.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants