Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_dynamic_url seems redundant in https://github.com/GoogleChrome/chrome-extensions-samples/blob/main/api-samples/web-accessible-resources/manifest.json #927

Open
NathanKr opened this issue May 22, 2023 · 2 comments

Comments

@NathanKr
Copy link

Describe the bug
use_dynamic_url is used in the manifest.json but the sample seems to work also when it is removed

To Reproduce
simply remove use_dynamic_url from the manifest and see everything is working like a charm

Expected behavior
I am expecting use_dynamic_url to make a difference. it should be removed if it does not

Notes
either remove use_dynamic_url or add a code that uses it

@shreya024
Copy link
Contributor

shreya024 commented May 23, 2023

@jpmedley I would like to work on this issue.Kindly assign

@tophf
Copy link

tophf commented Aug 20, 2023

It's not yet implemented, but it's good practice to use it so that web sites can't detect the presence of your extension. Actually, I'd argue this should be the default mode, just like it is in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants