refactor: use ESM modules #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 78.58% 87.48% +8.89%
==========================================
Files 36 24 -12
Lines 780 2198 +1418
Branches 0 3 +3
==========================================
+ Hits 613 1923 +1310
- Misses 167 275 +108
Continue to review full report at Codecov.
|
moabu
requested changes
Mar 2, 2022
| @@ -32,7 +32,7 @@ jobs: | |||
| node-version: 14 | |||
| - run: | | |||
| npm install --save-dev @commitlint/{config-conventional,cli} | |||
| echo "module.exports = {extends: ['@commitlint/config-conventional']};" > commitlint.config.js | |||
| echo "module.exports = {extends: ['@commitlint/config-conventional']};" > commitlint.config.cjs | |||
There was a problem hiding this comment.
Nope, It is correct. node-config need it. more details
|
Kudos, SonarCloud Quality Gate passed! |
|
run tests |
1 similar comment
|
run tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #409
Major Changes:
nycpackage does not support ESM modules. Usedc8instead of it.rewirepackage does not support ESM modules. For work around exports all submodules. There are other packages but they need to build usingbabel. more detailssinondoes not support ESM modules. Usedesmockinstead of it