Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): cloud_upload #2675

Open
greyscaled opened this issue Feb 21, 2024 · 3 comments
Open

test(integration): cloud_upload #2675

greyscaled opened this issue Feb 21, 2024 · 3 comments

Comments

@greyscaled
Copy link
Contributor

greyscaled commented Feb 21, 2024

As a follow-up to #2670:

we could probably write tests for this using mino or the mock gcs fixture

Originally posted by @tychoish in #2670 (comment)

@greyscaled
Copy link
Contributor Author

greyscaled commented Feb 21, 2024

I think mock gcs fixture would be best - but this code relies on a cloud instance. Do we have prior art for running such tests without reaching out to a test instance of glaredb cloud?

Intuitively, I'd think we can start a glaredb connected to the gcs fixture and then use a client to connect to it via pg or rpc.

If such a test or pieces of it exist, I'd be very thankful to be pointed to the code(s).

@tychoish
Copy link
Collaborator

I think it doesn't require cloud, as much as a glaredb invocation that has credentials for the service account that can access the buckets where native storage is, and one user, but I might be missing something

@greyscaled
Copy link
Contributor Author

greyscaled commented Feb 21, 2024

Yes I didn't mean to imply cloud is absolutely required the confusing phrase cloud instance arises from the name of the function on session vars.

Oops.

But ya I would think we need to run the binary with the right things configured and I'm unsure if we have any existing tests doing that so it may end up being a novel setup.

Will have bandwidth to look into this more in the coming sprints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants